Review Request: Improved animation lifecycle management

[Aaron J. Seigo]

On Thursday 14 February 2008, you wrote:
> The patch looks good, but I would prefer to have just one signal
> (animationComplete) for all types of animations

no, this means that every object listening to the signal would get signalled 
on every kind of animation, not just the ones it cares about. you can connect 
multiple signals to the same slot, so i only see a loss in flexibility and a 
greater number of slots being called with this approach.

> and have all animations return an AnimId. 

this does make sense if only because it allows Phase to eventually support 
multiple move/anims per item. normalizing things a bit is also good.

> I even sent a mail to the 
> list, but I didn't have time to
> work on it yet. Probaly next week I will make some kde related work again

cool =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080214/2edaa6e6/attachment.pgp