Review Request: Initialize x,y correctly in panel

[Aaron Seigo]

> On 2008-02-14 05:40:18, Marco Martin wrote:
> >
> 
> Marco Martin wrote:
>     damn review board and opera that don't get along so well :(
>     i was saying...
>     i don't have a second monitor so i can't test and what i say could be total nonsense..
>     but can the x of a monitor be > 0? if so the panel would draw the left side of the svg panel even if the panel is 100% wide that wouldn't be correct

both x and y can be > 0, but the checks for which edges to draw are on the x() and y() of the screen rect (r), so this patch is correct.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/132/#review124
-----------------------------------------------------------


On 2008-02-14 05:25:59, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/132/
> -----------------------------------------------------------
> 
> (Updated 2008-02-14 05:25:59)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I think x,y should be initialized to screen x,y and not 0,0.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/containments/panel/panel.cpp
> 
> Diff: http://matt.rogers.name/r/132/diff
> 
> 
> Testing
> -------
> 
> Seems to help to a weird problem that I had where panel on screen 1 was mirroring other panel on screen 0.
> 
> 
> Thanks,
> 
> Petri
> 
>