Review Request: Improved animation lifecycle management

[Marco Martin]

> On 2008-02-14 02:46:17, Andre Duffeck wrote:
> > looks good to me.

Looks good also to me, so now the background fading can be enabled again, woha :)
so now it will be necessary to use the elemantAnimationCompleted signal to display things that have finished to animate (so never display an appeared thing with phase but directly)?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/131/#review122
-----------------------------------------------------------


On 2008-02-14 02:18:33, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/131/
> -----------------------------------------------------------
> 
> (Updated 2008-02-14 02:18:33)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds consistent signals at the end of all animations and ties QObject lifespan (when available) to all the animations including elementAnimation. Also prevents multiple connections to the destroyed slots (harmless, just cycle wasting) and mutes some remaining debug statements.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/phase.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/phase.cpp
> 
> Diff: http://matt.rogers.name/r/131/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron
> 
>