Review Request: Improved animation lifecycle management

Aaron Seigo aseigo at kde.org
Thu Feb 14 09:18:33 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/131/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This patch adds consistent signals at the end of all animations and ties QObject lifespan (when available) to all the animations including elementAnimation. Also prevents multiple connections to the destroyed slots (harmless, just cycle wasting) and mutes some remaining debug statements.


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/phase.h
  /trunk/KDE/kdebase/workspace/libs/plasma/phase.cpp

Diff: http://matt.rogers.name/r/131/diff


Testing
-------


Thanks,

Aaron



More information about the Panel-devel mailing list