Review Request: News applet's configuration dialog modified to allow configuration of multiple feeds.

[Rob Scheepmaker]

On 2008-02-13 14:31:25, Rob Scheepmaker wrote:
> > Feeds with time use two columns and feeds without one column (ITEM_TIME / ITEM). If time exists is checked only from the first item.

Thanks, I've rewritten the html creation a bit: always have 2 columns, and print timeless items with colspan=2.


- Rob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/129/#review120
-----------------------------------------------------------


On 2008-02-13 13:41:36, Rob Scheepmaker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/129/
> -----------------------------------------------------------
> 
> (Updated 2008-02-13 13:41:36)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I've recently improved the RSS dataengine with support for multiple feeds (review pending: http://70.136.65.72/r/111/)
> This diff allows the news applet to actually make use of this, by changing the configuration dialog. I've also fixed some indentation issues.
> 
> 
> Diffs
> -----
> 
>   trunk/playground/base/plasma/applets/news/config.ui
>   trunk/playground/base/plasma/applets/news/news.h
>   trunk/playground/base/plasma/applets/news/news.cpp
> 
> Diff: http://matt.rogers.name/r/129/diff
> 
> 
> Testing
> -------
> 
> Tested with a couple of feeds. Most seems to work fine. The applet seems to have issues with mixing feeds with and without timestamps, I haven't looked into why this happens yet. Also the first update from the dataengine is incomplete.
> 
> 
> Thanks,
> 
> Rob
> 
>