Review Request: Better standard Size for BackgroundDialog

Aaron Seigo aseigo at kde.org
Wed Feb 13 16:28:00 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/127/#review118
-----------------------------------------------------------



trunk/KDE/kdebase/workspace/plasma/containments/desktop/backgrounddialog.cpp
<http://matt.rogers.name/r/127/#comment90>

    arbitrary sizes scare me ;) changes in fonts, language used, etc probably don't work well with this i'd imagine.
    
    getting rid of the blank space probably involves messing with the widget layout.


- Aaron


On 2008-02-13 06:04:05, Lukas  Appelhans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/127/
> -----------------------------------------------------------
> 
> (Updated 2008-02-13 06:04:05)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Hi!
> This patch sets a better standard Size for the Background-Dialog and removes the empty-space :)
> 
> Lukas
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/containments/desktop/backgrounddialog.h
>   trunk/KDE/kdebase/workspace/plasma/containments/desktop/backgrounddialog.cpp
> 
> Diff: http://matt.rogers.name/r/127/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukas
> 
>



More information about the Panel-devel mailing list