Review Request: Lock/Logout applet layout direction

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/122/#review113
-----------------------------------------------------------

Ship it!


i wanted to do something similar, so you beaten me, damn :D
i thik it's pretty ok, only one thing: maybe you want to add a call to checklayout() also in constraintsUpdated()?
or maybe moving the body in constraintupdated, but i'm not sure on it.

- Marco


On 2008-02-13 05:25:35, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/122/
> -----------------------------------------------------------
> 
> (Updated 2008-02-13 05:25:35)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> To change Lock/Logout applet layout direction depending on form factor and size.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/lock_logout/lockout.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/lock_logout/lockout.cpp
> 
> Diff: http://matt.rogers.name/r/122/diff
> 
> 
> Testing
> -------
> 
> Tested in vertical and horizontal panels.
> 
> 
> Thanks,
> 
> Petri
> 
>