Review Request: RSS dataengine now supports multiple feeds.

[Rob Scheepmaker]

> On 2008-02-11 12:25:34, Aaron Seigo wrote:
> > trunk/playground/base/plasma/engines/rss/rss.cpp, line 49
> > <http://matt.rogers.name/r/111/diff/1/#file276line49>
> >
> >     this will break if there is a legitimate ',' in the feed URL?

Well, applets using this engine should url encode the commas in the url's. Until there is some way to pass array's / lists to dataengines I don't think there's a better solution... But if there is, please suggest!


> On 2008-02-11 12:25:34, Aaron Seigo wrote:
> > trunk/playground/base/plasma/engines/rss/rss.cpp, line 59
> > <http://matt.rogers.name/r/111/diff/1/#file276line59>
> >
> >     this probably won't work quite as expected: visualizations will be connected to the source of the name passed into updateSource. so the individual feeds won't be picked up automatically by them, and this may end up clobbering other legitimate requests for these feeds individually.
> >     
> >     e.g. if one visualizations requests feed A, and another requests feed "A,B" then feed A will get updated more often than necessary and the second visualization won't get notified of changes to A or B individually at all.
> >     
> >     this also implies that all timing constraints will be thrown out the window as well for the individual sources.
> >     
> >     i'm not sure what is really gained by having the feeds  individually published when in a combined list?

As we've discussed on IRC, I'm going to modify the engine to only publish the requested feed(s), but have the engine cache the individual feeds, so network traffic is kept to a minimum.


> On 2008-02-11 12:25:34, Aaron Seigo wrote:
> > trunk/playground/base/plasma/engines/rss/rss.cpp, lines 77-79
> > <http://matt.rogers.name/r/111/diff/1/#file276line77>
> >
> >     Engines will at worst run in their own thread, but there are no plans to multithread individual engines. So if this came up as an issue, it would be because threading was added to the RssEngine directly.

*phew*... that's a relief. Thread's scare me...


- Rob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/111/#review104
-----------------------------------------------------------


On 2008-02-11 10:12:38, Rob Scheepmaker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/111/
> -----------------------------------------------------------
> 
> (Updated 2008-02-11 10:12:38)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> My first contribution to the KDE project! This diff should add support for requesting a comma separated list of multiple feeds from the RSS dataengine, which will merge the entries from the different feeds in one convenient time sorted list. I'm really new to QT / plasma, so I've probably done some things wrong... so I'm looking forward to getting feedback from people who actually know what they're doing. ;)
> 
> 
> Diffs
> -----
> 
>   trunk/playground/base/plasma/engines/rss/rss.h
>   trunk/playground/base/plasma/engines/rss/rss.cpp
> 
> Diff: http://matt.rogers.name/r/111/diff
> 
> 
> Testing
> -------
> 
> Not a lot atm. I've tested with both plasmaengineexplorer and the news applet in trunk. Feeding the news applet in trunk with a comma seperated list of url's shows that it works! Data abstraction rocks :). It seems however that the first time the data is requested, the feeds aren't really merged... the next update works fine. I'm still looking into that.
> 
> 
> Thanks,
> 
> Rob
> 
>