Review Request: Cleanup Notes Applet

Chani Armitage chanika at gmail.com
Mon Feb 11 13:47:41 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/109/#review102
-----------------------------------------------------------

Ship it!



/trunk/extragear/plasma/applets/notes/notes.cpp
<http://matt.rogers.name/r/109/#comment81>

    so when exactly is editingFinished emitted - when text focus leaves the note?


looks good to me.

so... who's planning to make sure the text is deleted from the config when the note is deleted? :) 

- Chani


On 2008-02-11 06:08:11, Sebastian Kuegler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/109/
> -----------------------------------------------------------
> 
> (Updated 2008-02-11 06:08:11)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> - codingstyle cleanups
> - Remove Notes-internal size handling, that's done by plasma itself
> - Remove unecessary saveNote(), we can do just fine with only one method saving the content
> 
> Result: 
> -1 String
> - 3 methods
> - 1 member var
> - ~80 LOC
> 
> Without visible regressions :-)
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/plasma/applets/notes/config.ui
>   /trunk/extragear/plasma/applets/notes/notes.h
>   /trunk/extragear/plasma/applets/notes/notes.cpp
> 
> Diff: http://matt.rogers.name/r/109/diff
> 
> 
> Testing
> -------
> 
> Compiled, resized, quit, restarted, all work as expected (modulo chani's remarks which should be in the queue)
> 
> 
> Thanks,
> 
> Sebastian
> 
>



More information about the Panel-devel mailing list