Review Request: Always single click in panel icons

Marco Martin notmart at gmail.com
Mon Feb 11 11:20:05 CET 2008



> On 2008-02-10 18:48:36, Aaron Seigo wrote:
> > i like it. only one problem:
> > 
> > if the form factor changes from horizontal to vertical, or from planar to mediacenter, the button will end up connected *twice* to the signal.
> > 
> > so instead, disconnect from *both* signals first (right after line 132) and then connect to the right signal in the if statements. that will work no matter what.

ok,done


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/100/#review96
-----------------------------------------------------------


On 2008-02-10 09:41:41, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/100/
> -----------------------------------------------------------
> 
> (Updated 2008-02-10 09:41:41)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Ok, this change is pretty trivial but changes the behaviour, so... :)
> when an icon applet is is the panel always activate it with the single click regardless of single/double click settings, don't think it makes much sense to activate them with double click, because i have serious problem to consider the panel a file manager view :)
> and maybe when/if the desktop folder will be visualized by its own plasmoid i think using always single click even in the desktop would make sense, but for now i would go single or double in the desktop and single in the panel
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/icon/icon.cpp
> 
> Diff: http://matt.rogers.name/r/100/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Panel-devel mailing list