Review Request: Smaller minimum size for digital clock so it fits in vertical panels too.

[Aaron Seigo]

> On 2008-02-10 08:18:20, Bill Egert wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp, line 91
> > <http://matt.rogers.name/r/98/diff/1/#file257line91>
> >
> >     Does the QString here need to take into account if the user is using 12 hour format?  "00:00 xM" or somthing goofy like that?
> >     
> >     Also if the show seconds option is enabled, it could potentialy become "00:00:00 xM".
> >     
> >     From paintInterface below, QString timeString = KGlobal::locale()->formatTime(m_time, m_showSeconds); might give you exactly what you need.  I am not sure though, I haven't tested this.

yes, formatTime would be more accurate, however ... you probably don't want to use m_time. instead use something like 23:59 for the time as it's likely the widest possibility.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/98/#review90
-----------------------------------------------------------


On 2008-02-10 05:56:52, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/98/
> -----------------------------------------------------------
> 
> (Updated 2008-02-10 05:56:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp
> 
> Diff: http://matt.rogers.name/r/98/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>