Review Request: Make kickoff use less vertical space in panel

Aaron Seigo aseigo at kde.org
Mon Feb 11 00:46:10 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/102/#review94
-----------------------------------------------------------


first patch! =) cool...

you can actually achieve squareness by calling setRemainSquare(true); in the constructor. remainSquare takes into consideration some unusual corner cases as well. i see that kickoff doesn't do that, however, which it indeed should. good catch! =)

do you have an svn account? if not, i'll commit the change for you, otherwise, you can..

- Aaron


On 2008-02-10 15:53:02, Beat Wolf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/102/
> -----------------------------------------------------------
> 
> (Updated 2008-02-10 15:53:02)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Kickoff uses too much vertical space in the panel.
> This is copy paste from device notifier, so that kickoff has always the same height as width.
> This is my first kde patch ever :-)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.h
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
> 
> Diff: http://matt.rogers.name/r/102/diff
> 
> 
> Testing
> -------
> 
> added kickoff to the panel and the desktop, changed sizes of kickoff on both.
> 
> 
> Screenshots
> -----------
> 
> Before the patch
>   http://matt.rogers.name/r/102/s/7/
> After the patch
>   http://matt.rogers.name/r/102/s/8/
> 
> 
> Thanks,
> 
> Beat
> 
>



More information about the Panel-devel mailing list