Review Request: Smaller minimum size for digital clock so it fits in vertical panels too.

[Bill Egert]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/98/#review90
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp
<http://matt.rogers.name/r/98/#comment77>

    Does the QString here need to take into account if the user is using 12 hour format?  "00:00 xM" or somthing goofy like that?
    
    Also if the show seconds option is enabled, it could potentialy become "00:00:00 xM".
    
    From paintInterface below, QString timeString = KGlobal::locale()->formatTime(m_time, m_showSeconds); might give you exactly what you need.  I am not sure though, I haven't tested this.


- Bill


On 2008-02-10 05:56:52, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/98/
> -----------------------------------------------------------
> 
> (Updated 2008-02-10 05:56:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp
> 
> Diff: http://matt.rogers.name/r/98/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>