Review Request: Automatic rate limiting of runners

Aaron Seigo aseigo at kde.org
Fri Feb 8 20:31:48 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/95/
-----------------------------------------------------------

(Updated 2008-02-08 13:31:48.943927)


Review request for Plasma.


Summary
-------

We rely on runners to set their speed, however this may not be accurate on all systems. The programmer may even misjudge it. This patch introduces automatic rate limiting based on real performance. If a runner takes too long to return and it isn't a HighPriority runner, we pop it down to Slow. If, however, a slowed runner returns matches 3 times in a row with enough speed then we promote it to Normal.


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/abstractrunner.cpp

Diff: http://matt.rogers.name/r/95/diff


Testing
-------

Ran with both fast runners that are slow, slow runners that are fast, and properly advertised runners. Speed was bumped (or not) appropriately.


Thanks,

Aaron



More information about the Panel-devel mailing list