[Bug 153872] Comic Strip Plasmoid does not load XKCD comic

Marco Martin notmart at gmail.com
Fri Feb 8 12:40:19 CET 2008


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153872         
notmart gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From notmart gmail com  2008-02-08 12:40 -------
SVN commit 772315 by mart:

This patch adds two items to the dataengine: "Next identifier suffix" and "Previous identifier suffix"
that says where to search the previous and next comics (if any) so now it's not tied to a date and to the concept of having one update a day.
and this fixes the xkcd comic (bug 153872)  that uses integer identifiers instead of dates for the comic
so now the logic to where search the next/previous is delegated to the comicprovider, and if there is no suffix the dataengine simply loads the today's comic.
the cache still works, but is disabled for today's comic, because it can become stale if it was actually an old comic and a new one is published today, and of course today it won't have a "Next identifier suffix" but tomorrow will.

BUG: 153872

 M  +18 -13    applets/comic/comic.cpp  
 M  +3 -1      applets/comic/comic.h  
 M  +14 -3     dataengines/comic/cachedprovider.cpp  
 M  +13 -1     dataengines/comic/cachedprovider.h  
 M  +75 -21    dataengines/comic/comic.cpp  
 M  +8 -1      dataengines/comic/comic.h  
 M  +9 -0      dataengines/comic/comicprovider.cpp  
 M  +23 -1     dataengines/comic/comicprovider.h  
 M  +19 -0     dataengines/comic/dilbertprovider.cpp  
 M  +4 -0      dataengines/comic/dilbertprovider.h  
 M  +20 -1     dataengines/comic/garfieldprovider.cpp  
 M  +4 -0      dataengines/comic/garfieldprovider.h  
 M  +24 -11    dataengines/comic/osnewsprovider.cpp  
 M  +4 -0      dataengines/comic/osnewsprovider.h  
 M  +19 -0     dataengines/comic/snoopyprovider.cpp  
 M  +4 -0      dataengines/comic/snoopyprovider.h  
 M  +19 -0     dataengines/comic/userfriendlyprovider.cpp  
 M  +4 -0      dataengines/comic/userfriendlyprovider.h  
 M  +51 -23    dataengines/comic/xkcdprovider.cpp  
 M  +5 -1      dataengines/comic/xkcdprovider.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=772315


More information about the Panel-devel mailing list