Review Request: Notifies the user of failure

Aaron Seigo aseigo at kde.org
Fri Feb 8 04:15:37 CET 2008



> On 2008-02-07 21:13:49, Aaron Seigo wrote:
> > Looks good! =)

Actually, I take that back somewhat. You need to wrap all the text in i18n(), so this:

setData( "Error", "Syndication Error", "Data download was aborted" );

becomes:

setData(i18n("Error"), i18n("Syndication Error"), i18n("Data download was aborted"));


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/92/#review80
-----------------------------------------------------------


On 2008-02-07 16:54:19, Henry de Valence wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/92/
> -----------------------------------------------------------
> 
> (Updated 2008-02-07 16:54:19)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/playground/base/plasma/engines/cia.vc/ciavc.cpp
> 
> Diff: http://matt.rogers.name/r/92/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Henry
> 
>



More information about the Panel-devel mailing list