Review Request: svg background on tooltips

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/91/#review78
-----------------------------------------------------------

Ship it!


other than the svg used (see below) looks good.


/trunk/KDE/kdebase/workspace/libs/plasma/widgets/tooltip.cpp
<http://matt.rogers.name/r/91/#comment70>

    it should probably use widgets/tooltip instead of dialogs/background (just copy dialogs/background over to widgets/tooltip in svn) and then be documented on the Theme page in the Plasma wiki.


- Aaron


On 2008-02-07 05:51:29, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/91/
> -----------------------------------------------------------
> 
> (Updated 2008-02-07 05:51:29)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This makes tooltips paint with the usual svg backgrounds, at the moment it uses dialogs/background, probably it will need a new one (maybe i will try to make one that looks like http://nuno-icons.com/images/estilo/image2274.png)
> it uses the new SvgPanel class and if compositing is not active it still make the window rounded
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/widgets/tooltip.cpp
> 
> Diff: http://matt.rogers.name/r/91/diff
> 
> 
> Testing
> -------
> 
> tried some tooltips of both tasks and icons with compositing active and inactive
> 
> 
> Screenshots
> -----------
> 
> tooltip with composite
>   http://matt.rogers.name/r/91/s/5/
> 
> 
> Thanks,
> 
> Marco
> 
>