Review Request: Emit changed() when compositing changes

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/90/#review77
-----------------------------------------------------------


nice! i was wondering if emitting some other signal besides changed() would be useful, something like compositionChanged(bool)
as a use case i wanted to still have the usual ugly rounded border in tooltips when compositing is not active, at the moment i check KWindowSystem::compositingActive() every time

- Marco


On 2008-02-06 22:44:00, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/90/
> -----------------------------------------------------------
> 
> (Updated 2008-02-06 22:44:00)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> When a compositor becomes available, we want to also switch the SVGs being painted. Since Theme knows the difference between composite and opaque images, I put the code for this in Theme. This results in Svg updating and calling repaintNeeded, which may be chained again through SvgPanel.
> 
> This will only work on X11 due to KSelectionWatcher being X11 specific. On all other platforms, it will just use whatever setting it finds on Theme object creation because the patch removes the check for compositing from every call to image(). This has no impact on X11, but means that if other platforms can turn on/off compositing at runtime that this won't work properly as is. I don't know if this is possible on MacOS or Windows, nor do I think it's a big enough issue to worry about.
> 
> Switching KWin composite on and seeing the top level windows change before your eyes is pretty sweet, though =)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/theme.cpp
> 
> Diff: http://matt.rogers.name/r/90/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron
> 
>