Review Request: Ensure that LayoutItem::setParent resets the parents layout if we are currently its layout and release managed items.
Aaron Seigo
aseigo at kde.org
Thu Feb 7 04:18:16 CET 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/89/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
This is just more safety stuff, not sure it really has any practical uses at this point. Reseting the parent of a Layout still doesn't auto-add the children of it, but since both the children are known only to the Widget and the method of adding them varies between layouts ..... i don't see a nice generic solution for this yet.
Note that this also a BIC change =/
Diffs
-----
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/borderlayout.h
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/borderlayout.cpp
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/boxlayout.h
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/boxlayout.cpp
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/flowlayout.h
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/flowlayout.cpp
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/freelayout.h
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/freelayout.cpp
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/layout.h
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/layout.cpp
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/nodelayout.h
/trunk/KDE/kdebase/workspace/libs/plasma/layouts/nodelayout.cpp
Diff: http://matt.rogers.name/r/89/diff
Testing
-------
Thanks,
Aaron
More information about the Panel-devel
mailing list