Review Request: safe layout switching

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/88/#review72
-----------------------------------------------------------

Ship it!


the containment.cpp patch is correct, the others are not needed though.


/trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
<http://matt.rogers.name/r/88/#comment59>

    this is correct ... with the stricter semantics now in svn, these kinds of things are incorrect. now it's consistent (the parent layoutitem takes ownership.. period.). good catch on this one though. please commit the changes to this file.



/trunk/KDE/kdebase/workspace/libs/plasma/layouts/layout.cpp
<http://matt.rogers.name/r/88/#comment58>

    actually, this needs to let the parent LayoutItem know if it has been deleted in case someone *else* deletes it behind the parent LayoutItem's back. i've guarded against such a case in svn.



/trunk/KDE/kdebase/workspace/libs/plasma/layouts/layoutitem.cpp
<http://matt.rogers.name/r/88/#comment57>

    not needed...


- Aaron


On 2008-02-06 17:56:10, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/88/
> -----------------------------------------------------------
> 
> (Updated 2008-02-06 17:56:10)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/layouts/layout.cpp
>   /trunk/KDE/kdebase/workspace/libs/plasma/layouts/layoutitem.cpp
> 
> Diff: http://matt.rogers.name/r/88/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>