Regression?

[Chani]

On February 7, 2008 07:06:23 Chani wrote:
> On February 7, 2008 06:56:20 Sebastian Sauer wrote:
> > On Wednesday 06 February 2008, you wrote:
> > > > which does in the Layout::Layout(LayoutItem *parent) ctor call
> > > > parent->setLayout(this) results somehow in an infinite loop calling
> > > > LayoutItem::setLayout(Layout* layout)
> > >
> > > does this patch fix it?
> >
> > unfortunately not :-/ Anyway, I'll try to investigate it tomorrow a bit
> > more in detail.
>
> the layout's destructor calls LayoutItem::setLayout(0) on the parent which
> then tries to delete the layout that's in the middle of being deleted...
> maybe we need a deleteLater() ? maybe the destructor shouldn't be calling
> that?

the more I think about it, the more it seems that the child shouldn't be 
telling the parent; the parent should be responsible for the child and nobody 
else should be allowed to delete the child. do we have any code anywhere that 
tries to delete a layout without first removing it from its parent?

-- 
This message brought to you by evyl bananas, and the number 3.
www.chani3.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: setlayout2.diff
Type: text/x-diff
Size: 648 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080207/a1366552/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080207/a1366552/attachment.pgp