Review Request: Remove background from the list when it is deleted on disk

Aaron Seigo aseigo at kde.org
Tue Feb 5 23:58:26 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/86/#review71
-----------------------------------------------------------

Ship it!


the removeBackground method isn't exactly efficient, but it's correct and efficiency probably doesn't matter one wit here since the model is small and there'll really only ever be a single instance of an item in there =)

- Aaron


On 2008-02-05 16:03:21, Paolo Capriotti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/86/
> -----------------------------------------------------------
> 
> (Updated 2008-02-05 16:03:21)
> 
> 
> Review request for Plasma, Aaron Seigo and Jeremy Whiting.
> 
> 
> Summary
> -------
> 
> This patch adds a KDirWatch to BackgroundListModel as suggested in http://bugs.kde.org/show_bug.cgi?id=155302. Should fix the bug.
> 
> 
> This addresses bug 155302.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/containments/desktop/backgrounddialog.h
>   /trunk/KDE/kdebase/workspace/plasma/containments/desktop/backgrounddialog.cpp
> 
> Diff: http://matt.rogers.name/r/86/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paolo
> 
>



More information about the Panel-devel mailing list