Review Request: Tooltip performance and behaviour improvements

Aaron Seigo aseigo at kde.org
Tue Feb 5 19:26:13 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/78/
-----------------------------------------------------------

(Updated 2008-02-05 12:26:13.068369)


Review request for Plasma.


Summary
-------

This does a fairly large number of things, mostly in the performance an behaviour dpt:

* set the palette on theme changes only
* don't grab the data until actually shown
* show the right size and position when we are showing the tip
* allow the tooltip to figure out it's size with the help of the widget (it knows when to do this, the widget only knows how)
* don't show the tip on every item's mouse over, respect the small timeout
* only create a ToolTipData struct for those items that actually use it (memory savings as well as makes the check for showing the tip a lot simpler)

I realize it's a lot of changes all in one patch, but they all kind of relate and overlap.


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/tooltip.cpp
  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/tooltip_p.h
  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/widget.h
  /trunk/KDE/kdebase/workspace/libs/plasma/widgets/widget.cpp

Diff: http://matt.rogers.name/r/78/diff


Testing
-------


Thanks,

Aaron



More information about the Panel-devel mailing list