Review Request: only use one qhttp object, now I can have less code for response handling

Anne-Marie Mahfouf annma at kde.org
Tue Feb 5 12:13:46 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/79/#review66
-----------------------------------------------------------

Ship it!


Tested, with existing config and after removing config file, no problem, works as fine as before!
As said the others, go for it provided you "constantify" the host string and you add the missing "break" as you noted on IRC!

- Anne-Marie


On 2008-02-05 01:46:53, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/79/
> -----------------------------------------------------------
> 
> (Updated 2008-02-05 01:46:53)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/plasma/dataengines/twitter/twitterengine.h
>   /trunk/extragear/plasma/dataengines/twitter/twitterengine.cpp
> 
> Diff: http://matt.rogers.name/r/79/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chani
> 
>



More information about the Panel-devel mailing list