Review Request: Make pager use plasma's colorscheme

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/51/#review47
-----------------------------------------------------------

Ship it!



/trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp
<http://matt.rogers.name/r/51/#comment49>

    this doesn't look right. 88x44 by default is 44x22x2 or 22*22 on a 2x2 grid (depend on whether you use 2 or 4 desktops). admitedly smallish, but sensible on a panel.


other than the above comment, it looks good. nicely done.

- Aaron


On 2008-02-03 11:41:12, Sebastian Kuegler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/51/
> -----------------------------------------------------------
> 
> (Updated 2008-02-03 11:41:12)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Make Plasma's pager applet use kcolorscheme and the font from the taskbar. Also make Plasma's colorscheme use colors from the Oxygen palette.
> 
> With this patch, the pager should be nicely themable.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp
>   /trunk/KDE/kdebase/workspace/plasma/desktoptheme/colors
> 
> Diff: http://matt.rogers.name/r/51/diff
> 
> 
> Testing
> -------
> 
> Compiled and played around with the colors.
> 
> 
> Screenshots
> -----------
> 
> With patch
>   http://matt.rogers.name/r/51/s/3/
> Without patch
>   http://matt.rogers.name/r/51/s/4/
> 
> 
> Thanks,
> 
> Sebastian
> 
>