Review Request: fix xkcd comic strip

[Jesper Thomschütz]

> On 2008-02-03 14:53:36, Marco Martin wrote:
> > i only have a little doubt (not sure if i understood correctly how it works, so correct me if i'm wrong): since datetoid calculates the id based on current id minus how far the date is from today, couldn't happen to skip some comics?
> > scenario: there is a comic published today and one four days ago. i ask for a comic three days ago and it returns the id of today minus three, so the comic of four days ago that is id of today minus one is skipped, but i really can't see how it could be done :(

A little bit off-topic perhaps, but it would perhaps make sense to make a general RSS/Atom comic provider? We could avoid issues like this just by using http://xkcd.com/atom.xml


- Jesper


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/54/#review42
-----------------------------------------------------------


On 2008-02-03 13:56:27, Jonas Pollok wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/54/
> -----------------------------------------------------------
> 
> (Updated 2008-02-03 13:56:27)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I tried to fix the xkcd part of the comic dataengine.
> xkcd uses incremental ids and not dates to identify a comic strip.
> The old code assumes that xkcd releases one comic strip per day which is not the case.
> I'll write down what i _wanted_ to do and you can either find a better way or improve the code :)
> 
> On creation the latest comic strip id is parsed from 'http://xkcd.com' and associated with currentDate().
> When requesting a comic strip by providing a certain date the delta between the given date and currentDate
> should be the delta between the wanted id and the latest id.
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/plasma/dataengines/comic/xkcdprovider.h
>   trunk/extragear/plasma/dataengines/comic/xkcdprovider.cpp
> 
> Diff: http://matt.rogers.name/r/54/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonas
> 
>