Review Request: fix xkcd comic strip

Jonas Pollok jonas.p at gmail.com
Sun Feb 3 20:56:27 CET 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/54/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

I tried to fix the xkcd part of the comic dataengine.
xkcd uses incremental ids and not dates to identify a comic strip.
The old code assumes that xkcd releases one comic strip per day which is not the case.
I'll write down what i _wanted_ to do and you can either find a better way or improve the code :)

On creation the latest comic strip id is parsed from 'http://xkcd.com' and associated with currentDate().
When requesting a comic strip by providing a certain date the delta between the given date and currentDate
should be the delta between the wanted id and the latest id.


Diffs
-----

  trunk/extragear/plasma/dataengines/comic/xkcdprovider.h
  trunk/extragear/plasma/dataengines/comic/xkcdprovider.cpp

Diff: http://matt.rogers.name/r/54/diff


Testing
-------


Thanks,

Jonas



More information about the Panel-devel mailing list