Review Request: reasonable applets size in bigger (probably vertical) panels

Marco Martin notmart at gmail.com
Sun Feb 3 16:41:05 CET 2008



> On None, Riccardo Iaconelli wrote:
> > Looks good to me (not tested, but...). Some other applets probably need to have a completely different look on this panel, and must be studied per-case. 'ship it' from me. =)

ok, i'll do it this evening, so there it's still some time to complain :D


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://matt.rogers.name/r/49/#review29
-----------------------------------------------------------


On 2008-02-03 09:21:32, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://matt.rogers.name/r/49/
> -----------------------------------------------------------
> 
> (Updated 2008-02-03 09:21:32)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this patch sets on Applet::constraintsUpdated() the maximum content width for horizontal panels and the maximum content height for vertical panels as IconSize(KIconLoader::Panel)
> this makes vertical larger panels actually usable.
> it works only for applets that aren't forced to square
> for horizontal panels only for applets that don't have expandingDirections()=Qt::Horizontal 
> for vertical panels only for applets that don't have expandingDirections()=Qt::Vertical
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/applet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/simpleapplet.h
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/simpleapplet.cpp
> 
> Diff: http://matt.rogers.name/r/49/diff
> 
> 
> Testing
> -------
> 
> tested with a panel with a taskbar, kickoff, a clock a systray and a device notifier, as shown in the screenshots
> plasma::icon aligns the icon in the center (like kickoff)
> kickon aligns it to the left (like device notifier) i think the aspect of plasma::icon is prettier
> other applets (like battery) should be taken into account and not be set as square when into the panel
> 
> 
> Screenshots
> -----------
> 
> (almost) pretty vertical taskbar
>   http://matt.rogers.name/r/49/s/1/
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Panel-devel mailing list