Review Request: Making panel toolbox to do something

Aaron Seigo aseigo at kde.org
Wed Apr 30 23:57:14 CEST 2008


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info:8080/r/326/#review322
-----------------------------------------------------------

Ship it!


- Aaron


On 2008-04-30 14:10:10, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://mattr.info:8080/r/326/
> -----------------------------------------------------------
> 
> (Updated 2008-04-30 14:10:10)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds a new class called PanelController that is a
> QWidget (as opposed to the previous patch) that will contain stuff for the panel configuration, at
> the moment it contains add widgets and remove panel, there is a very
> early implementation of panel resizing by drag and drop.
> it's a widget that it's drawn on top of the panel and with 100% width
> for two reasons:
> it must be a separate thing and not resize with the panel otherwise
> buttons and other controls won't fit
> the width must always be 100% to make the concept of the ruler for
> resizing the panel work
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.h
>   /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
>   /trunk/KDE/kdebase/workspace/plasma/plasma/CMakeLists.txt
>   /trunk/KDE/kdebase/workspace/plasma/plasma/panelview.h
>   /trunk/KDE/kdebase/workspace/plasma/plasma/panelview.cpp
> 
> Diff: http://mattr.info:8080/r/326/diff
> 
> 
> Testing
> -------
> 
> in this last revision everything works more or less as it is supposed to, except the resize handle seem to disappear in vertical panels
> 
> 
> Screenshots
> -----------
> 
> bottom panel controller
>   http://mattr.info:8080/r/326/s/39/
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Panel-devel mailing list