Review Request: Making panel toolbox to do something

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://mattr.info:8080/r/326/
-----------------------------------------------------------

(Updated 2008-04-30 06:55:32.080269)


Review request for Plasma.


Summary
-------

This patch adds a new class called PanelController that is a
QWidget (as opposed to the previous patch) that will contain stuff for the panel configuration, at
the moment it contains add widgets and remove panel, there is a very
early implementation of panel resizing by drag and drop.
it's a widget that it's drawn on top of the panel and with 100% width
for two reasons:
it must be a separate thing and not resize with the panel otherwise
buttons and other controls won't fit
the width must always be 100% to make the concept of the ruler for
resizing the panel work


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/plasma/containment.h
  /trunk/KDE/kdebase/workspace/libs/plasma/containment.cpp
  /trunk/KDE/kdebase/workspace/plasma/plasma/CMakeLists.txt
  /trunk/KDE/kdebase/workspace/plasma/plasma/panelview.h
  /trunk/KDE/kdebase/workspace/plasma/plasma/panelview.cpp

Diff: http://mattr.info:8080/r/326/diff


Testing
-------

resizing by drag and drop works for bottom panels, still problems of the widget placing for other panel orientations


Screenshots
-----------

ob bottom panel
  http://mattr.info:8080/r/326/s/39/


Thanks,

Marco