[PATCH] RunnerManager

[Ryan P. Bitanga]

2008/4/22 Aaron J. Seigo <aseigo at kde.org>:
> On Tuesday 22 April 2008, Ryan P. Bitanga wrote:
>  > IMHO we shouldn't be using heuristic algorithms for controlling the
>  > speed or priority lists for that matter. threadweaver has a priority
>  > queue of its own.
>
>  and how exactly will threadweaver know which thread to give priority to? i
>  agree that using QueuePolicy is a better approach, but we'll still need to
>  implement whatever directs canRun

I understand the reasons you wrote the rate-limiting heuristic but I
disagree in the implementation. Obviously there needs to be logic to
direct the ordering of the execution of runners as you pointed out but
IMO that would best be accomplished by calling setPriority. I'll see
if I recommend a better approach within the next few weeks. :) But I
must say your rate-limiting modifications got me thinking of taking a
page from Ingo Molnar's book and using a rb-tree, except that seemed
too heavyweight. Other scheduling approaches come to my mind but I am
loathe to add complexity to KRunner. I'll investigate soon.

Cheers,
Ryan