new panel look and feel

[Aaron J. Seigo]

On Sunday 20 April 2008, Marco Martin wrote:
> so since one cache is still needed i did that
> if (!d->useCache) {
>     delete d->panels[d->prefix];
>     d->panels.remove(oldPrefix);
> }
>
> in setElementPrefix()

sounds good.

as for the API itself, what about:

setUseCache -> setCacheAllRenderedPanels
useCache -> cacheAllRenderedPanels

it's longer, but states exactly what it does.

> > why not just put a:
> >
> > PanelData *panel = panels[prefix];
> >
> > at the start of the method and then replace all instances
> > of "panels[prefix]->" with "panel->"?
>
> less ugly, still not overgorgeous but yeah :)

indeed =/ well, it works and is, as you say, less ugly without much effort. if 
you wish to make pretty, you're right that the code will have to move into 
PanelData. since it's all private classes and code in the .cpp it's fine to 
move things around whenever. i'll leave it up to you and your sense of 
aesthetics =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080421/67af8c02/attachment.pgp