new panel look and feel

Aaron J. Seigo aseigo at kde.org
Sun Apr 20 20:56:23 CEST 2008


On Sunday 20 April 2008, Marco Martin wrote:
> hmm, there could be either an explicit clearCache() function that deletes
> everything but the currently used prefix

a little black-magicky, but optimizations often can be that way.

i wonder what the default policy should be: to cache or not to cache. it's 
really only the taskbar that currently needs/wants that, meaning that all 
other users of this class will have to call clearCache() whenever they wish 
to use it or else risk unecessary resource consumption.

it is probably better to have an attribute in SvgPanel that sets the cache 
policy, defaulting to no caching.

clearCache should remain, though, as it can be useful for when, e.g., the 
underlying svg updates or the widget itself wishes to clear it (since the 
widget using the SvgPanel object will often have better knowledge of this)

> another thing, now generateBackground is really cluttered of
> panels[prefix]-> 

yes, i noticed. not the best.

> couldn't that function goin paneldata? i'm hesitant of 

why not just put a:

PanelData *panel = panels[prefix];

at the start of the method and then replace all instances 
of "panels[prefix]->" with "panel->"? 

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20080420/df1fbbea/attachment.pgp 


More information about the Panel-devel mailing list