[Panel-devel] engines, applets and timing

[Aaron J. Seigo]

On Sunday 16 September 2007, Michael Olbrich wrote:
> On Sun, Sep 16, 2007 at 09:36:37AM -0600, Aaron J. Seigo wrote:
> > On Sunday 16 September 2007, Michael Olbrich wrote:
> > > checking the sender is a bit ugly but I didn't feel like writing an
> > > extra slot?
> >
> > except that now you've made it impossible to call disconnectVisualization
> > directly. this part of the patch is wrong.
>
> I don't think you understood that part.
> Calling disconnectVisualization on destroyed() is fine, but calling
> disconnect() in disconnectVisualization when it is called on destroyed()
> is not. It does not do anything but print an ugly warning.
> (sender() != visualization) is currently only false when
> disconnectVisualization is called on destroyed(). When
> disconnectVisualization is called directly sender() is 0 and disconnect
> is called.

ah .. so the goal was to get rid of a warning on the command line. i'm not 
sure if that's worth uglifying the code. it'll also break if we ever call 
disconnectVisualization via a signal other than destroyed(QObject*) =)

i'd prefer the benign warning ...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070916/953aae84/attachment.pgp