[Panel-devel] Applet updating

[Aaron J. Seigo]

On Sunday 16 September 2007, Petri Damsten wrote:
> Trying to get applet update behave similarly whether data is ready in
> DataEngine::updateSource() or not. After all applet writer should not have
> to know how engine gets it's data.

what's the use care for where it matters?

> 1. Data might not be ready yet so don't call update yet. It gets called
> when engine calls setData.

which breaks every call to connectSource to existing data sources. this part 
of the patch is wrong.

> Should update be called at start if engine does not call setData at all?

yes.

> 2. Call source with createWhenMissing true so DataContainer gets created
> even if setData is not called in DataEngine::updateSource()

this is incorrect; if the engine rejects the source request (returns false) 
the source should not be created.

> 3. queue to true so updated gets called after first setData

hm.. doesn't it already? or is this a side effect of not calling updated 
immediately as per point #1?

> 4. Don't update if it's queued

i wasn't sure about this one, tbh. by emitting always on the tick then graphs 
and other time-driven visualizations get their updates ... hm. but yes, it's 
probably better to not unless there's actual data .. so sure, commit this 
part of the patch.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070916/68cc6036/attachment-0001.pgp