[Panel-devel] dataengines and timing revisited

[Michael Olbrich]

On Fri, Aug 31, 2007 at 01:22:47PM -0600, Aaron J. Seigo wrote:
> On Friday 31 August 2007, Michael Olbrich wrote:
> > On Wed, Aug 29, 2007 at 08:40:58PM -0600, Aaron J. Seigo wrote:
> > >    - DataContainers are auto-removed appropriately
> >
> > This does not work right now. The problem is that disconnectNotify() is
> > only called for expicit disconnects and not when the receiver is
> > deleted. Atached is a patch that uses a different method to detect
> > unused DataContainers.
> > It also adds the actual deletion of the DataContainer. Currently the
> > memory is leaking.
> 
> it should still listen disconnectNotify events: an object may disconnect 
> without being deleted, and i don't trust that the only place that will ever 
> happen is in disconnectSource.
> 
> having to use invokeMethod (to queue the call for later) shows how ugly this 
> approach is, actually. there is the issue of items calling query() on a 
> source that isn't connected to anything else (and so gets created and then 
> just hangs out), but i'm really not very comfortable with the usage of 
> invokeMethod there.

New patch is attached. Better? Using invokeMethod is not strictly
necessary, but can avoid unnecessary deletion of the source. It
shouldn't be in any critical path though.

michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: container-delete2.diff
Type: text/x-diff
Size: 3529 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070901/a54028ed/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070901/a54028ed/attachment.pgp