[Panel-devel] [PATCH] QPixmapCache size (bug 151109)

[Sean Harmer]

On Wednesday 24 October 2007, Riccardo Iaconelli wrote:
> On Tuesday 23 October 2007 23:15:04 Zack Rusin wrote:
> > On Tuesday 23 October 2007 04:11:15 pm Riccardo Iaconelli wrote:
> > > On Tuesday 23 October 2007 22:03:45 Sean Harmer wrote:
> > > > Please find a proposed patch that attempts to automatically set the
> > > > size of the QPixmapCache for plasma to a size that is (hopefully)
> > > > suitable on an arbitrarily sized set of screens. I and many other
> > > > people have been bitten by this bug when testing out KDE 4 svn builds
> > > > and this is something that gives a bad impression form the word go.
> > > > So I thought I'd try a quick fix.
> > >
> > > I think the user should be able to configure that.
> >
> > I think not.
>
> Zack and I have talked a bit on IRC, and we've clarified. =)
>
> The best thing we should do then is to grow and resize automatically the
> space taken up by the cache basing on the pixmaps that are going in there.
> So that we will take the actual space that is needed by the pixmaps,
> nothing more, nothing less.
>
> What do you think of that?
I think that could work as long as we are careful to flush unneeded items from 
the cache so that it doesn't grow indefinitely. Although, some thought should 
be given to how the cache handles such use cases. That is, will it lead to 
thrashing of the cache and/or memory fragmentation? I don't know the answer 
to this at present as I have no idea on the implementation of QPixmapCache.

I'll spend some time getting more familiar with the structure of plasma and 
see what I can come up with.

Cheers,

Sean

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.