[Panel-devel] KDE/kdebase/workspace/plasma/applets/kickoff/ui

[Aaron J. Seigo]

On Tuesday 23 October 2007, Robert Knight wrote:
> SVN commit 728664 by knight:
>
> Revert back to the previous hover/selected indicator for items:  Draw the
> item background using the palette's highlight color and the text using the
> palette's highlighted text color.  The use of bold made it difficult for me
> to spot which item was selected, particular when manipulating items with
> the context menu.

this is extremely ugly, not only because it's a big block of colour but 
because that big block of colour is ... a block. it would look *slightly* 
better if it had rounded edges and a nice gradient to it (see dolphin's 
delegate)... but even then in this context it'll never be great due to the 
closeness and dimensions of the items ..... it also contrasts horribly with 
things like the green bars on the My Computer page.. ugh.

if the issue is context menu visibility then i can suggest two approaches:

- paint differently when there is a context menu on the item
- relect the context in the menu so people know what it is talking about

"Add to Favorites", as an example, should probably be "Add %1 to Favorites", 
etc. anyways... 

there are also paint errors (that were there before) when you right click on 
an item, then left click on a different item elsewhere in the menu, then 
right click on that item ... both get highlighted.. that was there before 
your change, of course, but now it's really badly visible.

but let's please go back to the more elegant and less "hello 1988, let's 
invert-the-text" approach and address any real problems in some other way.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071023/9f8c9ad0/attachment.pgp