[Panel-devel] [PATCH] kickoff

[Robert Knight]

> here's a new version of hover_selection.diff

That new version seems to be using a different diff format to the
other patches.  Could you re-post it using the same format as the
others (which I think is unified diff ala. svn diff)?

On 11/10/2007, Robert Knight <robertknight at gmail.com> wrote:
> Hi Aaron,
>
> I'll try to discuss visual/conceptual changes separately from the code
> itself.  In response to the comments in your first email:
>
> > i've noticed that the top margins are different from page to page, and the
> top
> > margin on the first header item in each page seems a bit excessive? patch
> > attached for that.
>
> Sounds good, thanks.
>
> > the headers should also be biased slightly "down" so they are closer to
> the
> > contents below than the contents above to provide visual grouping.
>
> Yes, that makes sense.
>
> > what do you think about moving System Settings into Places?
>
> It isn't a place as such, but a tool.  In the KDE 3 version, System
> Settings (or the distribution's own equivalent) is listed under an
> "Applications" category.
>
> > and how about on the Favorites page adding a header item, e.g.
> "Favorites"?
> > patch attached for that as well...
>
> I think that would be redundant.  The headers are only needed to
> separate groups of items on the same page.
>
> > i figure we can either add a header to the first list on the Applications
> tab
> > and make those headers look like the rest of the headers
>
> I'm treating the order of the tabs as fixed at the moment.  I can see
> that they have been rearranged between OpenSuSE 10.2 to OpenSuSE 10.3
> based on feedback, so I'm using the same tab layout as in OpenSuSE
> 10.3.
>
> When you say "visually inconsistent," could you expand on that?  I
> think that adding a header would be redundant, but we could try to
> align the items from tab to tab.
>
> > i do wonder about the general order of the tabs ... i almost would expect
> > favorites and recently used to be next to each other
>
> Favorites and Recently Used were next to each other in the original
> version of Kickoff, but the current tab layout mirrors OpenSuSE 10.3,
> I presume the changes were made following user feedback.  You'd have
> to ask the Stephan and co. for more information.
>
> > DnD from the app list to the favourites or recently used tabs would also
> be
> > tres cool. something for 4.1 maybe =)
>
> I think that DnD is quite an important part of the design, so I'd like
> to have it done for 4.0.
>
> Regards,
> Robert.
>
> On 11/10/2007, Aaron J. Seigo <aseigo at kde.org> wrote:
> > On Wednesday 10 October 2007, Aaron J. Seigo wrote:
> > > Robert: what do you think of the patches and above comments?
> >
> > another patch, this time for FlipScrollView which makes the header
> painting
> > a
> > lot more like the rest of the items.
> >
> > an update to the item hover painting as well. i really don't like the
> > highlight color backgrounds (it's too much color imho; and the rectangles
> > were both too large (abutts the next/previous items) and pretty old skool
> > with those hard corners). so i went for something more visually "elegant":
> > bold titles, subtext becomes un-greyed ... it's really nice now imho.
> >
> > i played with some other effects (changing icon sizes, etc) but rejected
> > various other ideas i tried out.
> >
> > i'm getting pretty happy with the way it looks and works now...
> >
> > --
> > Aaron J. Seigo
> > humru othro a kohnu se
> > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
> >
> > KDE core developer sponsored by Trolltech
> >
>