[Panel-devel] kalming kickoff

[Robert Knight]

> i was not happy with your first reversion, i gave ample warning of exactly
> what i was going to do and understood we were in agreement for "something
> better eventually" so committing something that was not in line with that
> without discussion is not acceptable.

Firstly, I must re-state is that the item appearance on hover is now
Dolphin-esque as we originally agreed.  I accept that I should have
contacted you before reverting your change initially rather than the
other way around.  However, when I did contact you, I gave clear
reasons for reverting to the previous code - and as the maintainer it
is my prerogative to do so.  However, you then proceeded to
re-implement your change again without mentioning it in the commit log
or CCing me or panel-devel (either would have been acceptable).  ( rv.
#733972 "lots of code no longer necessary as applets can usually just
ignore the whole background thin" ).  This is most certainly not
acceptable.

> heh.. you're committing my patches? .. interesting, and thanks for the
> conflicts that will ensue.

Not exactly.  In several cases I refactored existing code (outside of
the patch) in the process and then committed modified versions of the
code from the patch.  Some parts of your patch (such as the launcher
border) need changes or further discussion first.

> such as right now it still thinks it "THE_BOTHERSOME_MAN"
> even though I haven't had that DVD

Possibly a bug in Solid or HAL?

> perhaps this is one for the Solid folks,
> since "Volume" as a product title is pretty ... unhelpful?

Agreed.  I'm sure there is a more helpful title that could be used.

> i'm not a huge fan of the "just make it configurable" approach when avoidable.

That is my opinion as well.  In this case I couldn't think of a good
automatic solution, hence I proposed an option.



On 12/11/2007, Aaron J. Seigo <aseigo at kde.org> wrote:
> On Monday 12 November 2007, Robert Knight wrote:
> > > - swap the path with the product name in the My Computer view (not 100%
> > > sure i like this one yet, though it does give me more info =)
> >
> > I think that will depend on an individual user's storage setup as to
> > whether the volume name or the path is more useful.
> >
> > On my setup, using the volume name is more useful (eg. "ROB's iPod
> > instead of '/media/xyz0" , "Ubuntu 7.10" instead of '/media/cdrom0')
> > but I can quite imagine it will be the other way round on yours.
>
> It works for the CD device ... when it has a lable. Interestingly this has
> some subtle bugs, such as right now it still thinks it "THE_BOTHERSOME_MAN"
> even though I haven't had that DVD in the tray for 2 weeks now (and had
> several others since).
>
> > I would recommend using the volume name by default, simply because it
> > is usually a more friendly string to look at,
>
> the issue is that on many systems what we'll get is: Volume (ext3) for each
> disk, including USB discs. perhaps this is one for the Solid folks,
> since "Volume" as a product title is pretty ... unhelpful?
>
> The name information (e.g. "ROB'S iPod") it still shown in the subtext, of
> course.
>
> >  but by all means, add a preference to show the path instead.
>
> i'm not a huge fan of the "just make it configurable" approach when
> avoidable.
>
> > Equally, I think it likely that
> > some users would prefer to see the actual application name instead of
> > the generic name in the applications view.  Although the generic name
> > is a good default choice for new users.
>
> yes, we had this option in kde3 as well ...
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>