[Panel-devel] RFC: standard background

[Aaron J. Seigo]

hi...

so many applets have this code in them:

void MyApplet::constraintsUpdated(Plasma::Constraints)
{
     if (formFactor() == Plasma::Vertical ||
        formFactor() == Plasma::Horizontal) {
        setDrawStandardBackground(false);
    } else {
        setDrawStandardBackground(true);
    }

we already disable the background now on panels automagically. i'm thinking we 
should just go the extra step turn it on/off for the applets before 
contraintsUpdated is called ..... and then applets that don't want the 
standard background can just call setDrawStandardBackground(false);

far less code dupe and the exact same resulting effect.

i also think the default background needs a slightly thinner border =) i'll 
talk to the artists about that.

thoughts?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071104/e894df94/attachment.pgp