[Panel-devel] SolidDeviceEngine

[Petri Damstén]

On Thursday 01 November 2007 21:20:05 Aaron J. Seigo wrote:
> this should not be necessary:
>
>  if (!sources().contains(name)) {
>
> because if it does exist, it just replaces the old data with the new. which
> is probably what you want: the latest information, right?

Yes. Removed.

> as a side note, i'd personally put the filling of devicelist into its own
> method ... huge, long methods that sprawl on forever are really nasty
> looking and produce the sorts of hard-to-read patches like yours (which is
> mostly just whitespace changes) ...

fillDevices function added.

new patch attached.

-- 
If the Earth is the size of a pea in New York, then the Sun
is a beachball 50m away, Pluto is 4km away, and the next
nearest star is in Tokyo.  Now shrink Pluto's orbit into a
coffee cup; then our Milky Way Galaxy fills North America.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SolidDeviceEngine.diff
Type: text/x-diff
Size: 14260 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071101/c463a5e0/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071101/c463a5e0/attachment.pgp