[Panel-devel] KDE/kdebase/workspace/plasma/lib

[Aaron J. Seigo]

On March 1, 2007, Alexander Wiedenbruch wrote:
> SVN commit 638393 by wirr:
>
> Move the InputBox from SuperKaramba to Plasma.
>
>
>  M  +6 -0      CMakeLists.txt
>  M  +1 -1      datavisualization.h
>  A             widgets (directory)
>  A             widgets/lineedit.cpp   [License: GPL (v2+)]
>  A             widgets/lineedit.h   [License: GPL (v2+)]

this won't work; libplasma is lgpl. so either this needs to move into plasma 
itself, or we could just use QGraphicsTextItem, no?

yes, this would mean special casing the construction of this one widget a bit; 
if we keep the "set the size in the ctor" feature of Widget then we could 
also subclass QGraphicsTextItem and provide a compatible ctor at least. ditto 
for the svg and pixmap items.

>  A             widgets/widget.cpp   [License: LGPL (v2)]
>  A             widgets/widget.h   [License: LGPL (v2)]

i see this implements the (pure virtual) boundingRect(). i suppose the 
question is whether or not makes any sense to set the size in the 
constructor?

additionally, this class is missing a dptr and a setter for m_boundingBox. 
also, could we call it m_size since that's the parameter in the ctor?

finally, everything in libplasma should be in the Plasma namespace. i've 
fixing Runner right now, actually.

what else are you planning on implementing in Widget, if anything?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070302/dc6198ba/attachment.pgp