[Panel-devel] KDE/kdebase/workspace

[Aaron J. Seigo]

On Monday 30 July 2007, Sebastian Sauer wrote:
> Aaron J. Seigo wrote:
> > On Monday 30 July 2007, Sebastian Sauer wrote:
> >> plasma1.patch goes the most easy way to just allow an applet to change
> >> the menu. Probably it would be also an idea to just pass a
> >> KActionCollection/KAction's and add them to the menu cause that way we
> >> arn't limited to a kmenu for the context-stuff
> >
> > yes, i like the idea of retrieving QActions. a lot. QList<QAction*>
> > contextMenuActions() would be ok, except that "contextMenu" implies a
> > menu and you are right that this might be used in non-menu UI, but .. i
> > think that's ok. there should probably also be a contextMenuComplete()
> > signal so that applets that care to can do a cleanup of their actions...
>
> Patch attached :)

looks great; only change i'd make is to only add the separate 
if !actions.isEmpty()... i'm also not sure this method should be const 
because the actions may well get created in that method. please commit at 
your leisure.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070730/fd81b1c2/attachment.pgp