[Panel-devel] KDE/kdebase/workspace
Aaron J. Seigo
aseigo at kde.org
Fri Jul 27 23:10:47 CEST 2007
On Thursday 26 July 2007, Laurent Montel wrote:
> SVN commit 693020 by mlaurent:
>
> Allow to lock applet position
>
>
> M +19 -0 libs/plasma/applet.cpp
> M +9 -0 libs/plasma/applet.h
> M +6 -0 plasma/plasma/desktopview.cpp
besides the fact that this commit does not follow the coding guidelines (e.g.
uses tabs instead of spaces), was not peer reviewed (that i know of?) and
introduces new public API without apidox ........
... why do we want to lock the position of an applet? yes, i know SK did this,
but i don't see the use case for it in plasma. can you provide a reason why
we should offer "Lock" in the context menu?
the patch is also broken in numerous ways, primarily surrounding kiosk and
immutability. *if* we offer per-applet locking, it should simply call
setImmutable.
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20070727/cb8e9767/attachment.pgp
More information about the Panel-devel
mailing list