[Panel-devel] [PATCH] tooltips + taskbar thumbnails

[Aaron J. Seigo]

On Thursday 27 December 2007, Jason Stubbs wrote:
> On Friday 28 December 2007 10:56:28 Aaron J. Seigo wrote:
> > On Thursday 27 December 2007, Jason Stubbs wrote:
> > > On Thursday 27 December 2007 16:50:59 JST, Chani wrote:
> > > > having applet menu options in the task context menu would be much
> > > > less ugly, of course. the problem I see (from briefly glancing at the
> > > > code) is that the task management code currently hands us a
> > > > TaskRMBMenu, instead of something we can easily add to like a list of
> > > > QActions...
> > >
> > > As chatted about on IRC, I've worked up a patch that adds a new virtual
> > > to Applet that can be overridden to return a menu based on a given
> > > point. The
> >
> > why not just add a QPoint& to contextActions?
>
> That's what I was originally thinking to do. However, that would mean that
> the task's context menu would essentially be appended to the applet's
> rather than the applet's context menu becoming a submenu of task's, which I
> thought may be a little bit confusing.

couldn't you do it either way? e.g. make the contextActions the main part of 
the menu? there could be some simple heuristic, e.g. if there are 3 or more 
actions returned by contextActions make the applet's menu actions a submenu 
and make the contextActions the top level items...

> There's also the issue of object ownership. TaskRMBMenu is essentially
> designed to be a throw away menu but contextActions is designed so that
> actions are owned and managed by the applet. With a lot of refactoring
> TaskRMBMenu could be made to fit into that, but I figure that this issue is
> bound to crop up again.

Task[LR]MBMenu should probably just be turned into a collection of QActions 
that can then be used by whatever is consuming them.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071227/0ef1899e/attachment.pgp