[Panel-devel] [PATCH] More toolbox changes

[Aaron J. Seigo]

On Monday 24 December 2007, Craig Duquette wrote:
> Not sure if the code is the best for the toolbox staying in place, I had to
> create another method in Containment in order to actually access the
> toolbox.

we don't use "get" as part of methods. it would be just toolbox(). however, i 
don't like this as it means exporting the toolbox class, something i'd like 
to really avoid.

hm... i think it would probably make more sense to do this in Containment 
itself within the itemChange method, triggered by 
QGraphicsItem::ItemTransformChange

that means we don't need to provide access to the toolbox at all.

> I personally don't think the toolbox belongs inside of the containment
> because if there are multiple containments, we're going to have multiple
> toolboxes. I think it has more of a place in corona personally..

no, it belongs in the containment as that is the context of the items shown in 
it. it isn't global to corona at all.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071227/1f5cb212/attachment.pgp