[Panel-devel] [PATCH] Icon mutilation

[Jason Stubbs]

On Thursday 27 December 2007 02:36:17 JST Marco Martin wrote:
> the alignment property is used only in Icon::Private::iconPosition and is
> used to calculate the qrect containing the icon, and i think it would only
> make sense in the following ways:
> if the orientation is vertical it should be Qt::AlignHCenter | Qt::AlignTop
> if the orientation is horizontal it should be
> (Qt::AlignVCenter|Qt::AlignLeft) if the orientation is horizontal and
> plasma was called as
> plasma --reverselayout it should be (Qt::AlignVCenter|Qt::AlignRight)

Ok, that makes perfect sense now. :)

Perhaps the alignment should be Qt::AlignCenter when there is no text at all?
But then again, perhaps not seeing it wouldn't make any visible difference in 
any of the existing applets afaik.

Other than that, sounds perfect. :)

-- 
Jason Stubbs