[Panel-devel] [PATCH] tooltips + taskbar thumbnails

[Sebastian Kügler]

On Wednesday 26 December 2007 02:50:01 Jason Stubbs wrote:
> On Wednesday 26 December 2007 04:14:54 Sebastian Kügler wrote:
> > KWin composite provides those cool thumbnails of windows on the taskbar.
> > Plasma provides tooltips on taskbar entries. Those clash, as shown in the
> > attached screenshot.
> >
> > The attached patch checks by means of reading kwinrc if those taskbar
> > thumbnails are enabled and doesn't display the tooltips in that case.
> >
> > Objections against this patch? Suggestions for improvements?
>
> I don't particularly like it... If kwin decides to change its config layout
> or if the name of the taskbar thumbnail effect changes, this patch will
> break. Also, if the user makes changes to settings the user can end up with
> both tooltips or no tooltips for the remainder of the session. If the
> taskbar thumbnail effect is enabled but composite is disabled, the user
> will also end up with no tooltips. In an environment where the thumbnail
> effect doesn't do anything (like mine) the user will also end up with no
> tooltips.
>
> The taskbar thumbnail effect currently works by checking if the mouse
> position is within the published geometry on every single mouse move and is
> more of a quick hack to show what can be done - hence, demo in its name.
> I'm not sure if it'll remain for kde 4.0 or not, but I think it'd be much
> better to work with the kwin team to sort this out rather than working
> around it.

I do agree to your points. My patch was more a quick hack to make this 
situation suck less than it currently does. I am using those taskbar 
thumbnails, and there's just no way to remove those tooltips. Sure it can 
break, and sure it's not a nice piece of code, but it *does* lighten some 
cases and it makes it at least possible to have the taskbar working without 
major visual glitches (even if it might take re-logging in).

How about adding a check for composite, and putting it in at least for 4.0? (I 
hope the taskbar will see much love then anyway, right now it kind of sucks 
(little options, two rows would be nice, grouping isn't done, ...)

> > Otherwise, I'll commit shortly...
>
> Not sure if I made the cutoff time or not. ;)

You did, but I'd still like this situation to be solved ...
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071226/e1615d4f/attachment.pgp