[Panel-devel] [PATCH] on icon resizing

Aaron J. Seigo aseigo at kde.org
Fri Dec 21 06:17:38 CET 2007


On Thursday 20 December 2007, Marco Martin wrote:
> about the icon widget i have another doubt: is the method calculatesize()
> still needed at all?

looking at it some more, some things need to die IMHO:

- setIconSize: this implies that the icon can free change its size. i don't 
think that's realistic. if anything, we can limit the number of lines of 
text, but the size of the icon should just be figured out based on what the 
size() of the widget is

- margins: not sure why this was added particularly, other than to make it 
work with icon views in Qt or whatever silly thing. but this gives rise to 
the problems that Craig is seeing. they should just be removed completely.

Marco: feel like doing such code amputations? =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071220/f98640dc/attachment.pgp 


More information about the Panel-devel mailing list